Fix tab switcher menu button visibility on real devices #6890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes duckduckgo#6702 - Tab switcher '...' menu is invisible The issue was that the popup menu button was only having its isEnabled property set, but not its isVisible property. On some Android devices and different Android versions/themes, disabled menu items can become invisible or very faint, which caused the menu to not appear on real devices while still being visible on virtual devices. This fix ensures the popup menu button is always visible by explicitly setting isVisible = true, regardless of the enabled state. - Set explicit visibility for popup menu toolbar button - Add comment explaining the fix for future reference
…-b277f6c81ac5 Fix tab switcher menu button visibility on real devices
|
Hi maintainers! 👋 This PR fixes issue #6702 - Tab switcher '...' menu is invisible on real devices. Quick Summary:
Ready for Review: Thanks! 🙏 Fixes #6702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6702 - Tab switcher '...' menu is invisible
The issue was that the popup menu button was only having its
isEnabledproperty set, but not itsisVisibleproperty. On some Android devices and different Android versions/themes, disabled menu items can become invisible or very faint, which caused the menu to not appear on real devices while still being visible on virtual devices.Changes Made
isVisible = truefor the popup menu toolbar button inTabSwitcherMenuExt.ktTesting
The fix addresses the root cause by ensuring the menu button visibility is explicitly controlled, which should resolve the difference in behavior between virtual and real devices.
Root Cause Analysis
The issue occurred because:
isEnabledset based ondynamicMenu.isMenuButtonEnabledThis fix ensures consistent behavior across all devices by explicitly controlling visibility.